Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: circuits/circuits
base: 68c3b28f55ae^
Choose a base ref
...
head repository: circuits/circuits
compare: 4c377ed17f15
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 24, 2019

  1. Fix python2 str(circuits.core.values.Value()) 

    I am not sure why Value has a __str__ method at all. But it's broken on
python2. It assumes value is always a unicode-string, while coroutines
can return anything, even lists. This causes various crashes.

>>> str(circuits.core.values.Value())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fbest/git/circuits/circuits/six.py", line 854, in <lambda>
    klass.__str__ = lambda self: self.__unicode__().encode('utf-8')
  File "/home/fbest/git/circuits/circuits/core/values.py", line 78, in __str__
    return self.value.encode('utf-8')
AttributeError: 'NoneType' object has no attribute 'encode'
    @spaceone
    spaceone committed Jan 24, 2019
    Copy the full SHA
    3c7c56e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-str-value'

    @spaceone
    spaceone committed Jan 24, 2019
    Copy the full SHA
    68c3b28 View commit details
    Browse the repository at this point in the history

  3. Do not let global build fail if isort/flake8 fails

    @spaceone
    spaceone committed Jan 24, 2019
    Copy the full SHA
    4c377ed View commit details
    Browse the repository at this point in the history