Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpfm: use placeholder for PREFIX #52599

Merged
merged 1 commit into from Dec 21, 2018
Merged

libpfm: use placeholder for PREFIX #52599

merged 1 commit into from Dec 21, 2018

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Dec 20, 2018 •
edited

Motivation for this change

Enables cross-compilation of libpfm.

Things done

libpfm has its own ARCH strings, which are detailed in config.mk. This PR generates the correct string from the hostPlatform.

I tested cross builds for armv6l, armv7l and aarch64 as well as a native build on x86_64.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
Copy link
Contributor Author

Should this go in staging? LLVM depends on it.

@lopsided98 lopsided98 changed the base branch from master to staging December 21, 2018 19:32
@lopsided98 lopsided98 changed the base branch from staging to master December 21, 2018 19:32
@Mic92
Copy link
Member

Mic92 commented Dec 21, 2018

This is already fixed in staging: #51154

@Mic92
Copy link
Member

Mic92 commented Dec 21, 2018

You could also set PREFIX there though.

@Mic92
Copy link
Member

Mic92 commented Dec 21, 2018 •
edited

Btw. llvm cross-compilation is also fixed in staging. A solution for llvm-config is required though.

@lopsided98
Copy link
Contributor Author

Ok, I'll rebase this on top of staging with the PREFIX changes.

@Mic92 Mic92 merged commit 0a2efa1 into NixOS:staging Dec 21, 2018
@lopsided98 lopsided98 deleted the libpfm-cross branch December 21, 2018 21:16
@jtojnar jtojnar mentioned this pull request Dec 22, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@jtojnar jtojnar jtojnar left review comments

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

@ttuegel ttuegel Awaiting requested review from ttuegel

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lopsided98 @Mic92 @matthewbauer @jtojnar @GrahamcOfBorg