Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] firefox: 63.0.3 -> 64.0 #52598

Merged
merged 2 commits into from Dec 21, 2018
Merged

[18.09] firefox: 63.0.3 -> 64.0 #52598

merged 2 commits into from Dec 21, 2018

Conversation

andir
Copy link
Member

@andir andir commented Dec 20, 2018

Motivation for this change

Port of #51863 to 18.09.

This is not the syncing of the expressions from unstable to master but it carries the necessary changes for 18.09.

I am currently on vacation and travelling so I might not be around to react to comments. Feel free to (force) push changes to this PR if required.

Firefox did build successfully on this MR for me and the nixos tests also ran successfully.

/cc @vcunat @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
firefox: updated common.nix to support ffx64
9a9a7cc 
(cherry picked from commit 93a9e62)
@andir
firefox: 63.0.3 -> 64.0
232f20d 
(cherry picked from commit d8cde68)
vcunat
vcunat approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs OK for me.

@vcunat vcunat merged commit 232f20d into NixOS:release-18.09 Dec 21, 2018
vcunat added a commit that referenced this pull request Dec 21, 2018
@vcunat
Merge #52598: firefox: 63.0.3 -> 64.0
e55e8ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @vcunat @GrahamcOfBorg