You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks pkgs/applications/version-management/gitlab/update.py, for gitlab-workhorse (like it's already broken for gitlab-shell, see description of #50962):
For some weird reason in how go packages are being built, meta.position for gitlab-shell points to pkgs/development/go-modules/generic/default.nix, so update-source-version isn't able to bump this automatically (but we show the version and hash to bump to on the console).
Since then, the discovered location meta.position seems to have moved again: `
/nix/store/5chw603011946kg8w42961zsp4p4shr9-common-updater-scripts/bin/.update-source-version-wrapped: error: Couldn't locate old source hash '1r75jj0xb4jv5fq2ihxk0vlv43gsk523zx86076mwph1g75gi1nz' (or it appeared more than once) in '/home/flokli/dev/nixos/nixpkgs-2/lib/attrsets.nix'!
I agree it makes a lot of sense to switch to buildGoPackage, but updating gitlab and all dependencies is a bit complicated to do manually - so having tooling for it is nice.
Any idea how to fix update-source-version for buildGoPackage derivations?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Part of #52469, make the
gitlab-workhorstderivation usingbuildGoPackage馃懠Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)