Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnugrep: 3.1 -> 3.3 #52577

Merged
merged 2 commits into from Dec 29, 2018
Merged

gnugrep: 3.1 -> 3.3 #52577

merged 2 commits into from Dec 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 20, 2018

https://savannah.gnu.org/forum/forum.php?forum_id=9332

Similar to gnused update, hash not obtained from mirrors
(since they currently 404 for this) but nix-prefetch-url
on master gnu site.

Motivation for this change

For christmas I got you a big stack of rebuilds! ;)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

https://savannah.gnu.org/forum/forum.php?forum_id=9332

Similar to gnused update, hash not obtained from mirrors
(since they currently 404 for this) but nix-prefetch-url
on master gnu site.
Fixes bug in some uses of '\b' in certain locales;
same bug was introduced and fixed in gnused 4.6 -> 4.7.
@dtzWill dtzWill changed the title gnugrep: 3.1 -> 3.2 gnugrep: 3.1 -> 3.3 Dec 21, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 22, 2018

@GrahamcOfBorg build gnugrep

@jtojnar jtojnar mentioned this pull request Dec 26, 2018
@dtzWill dtzWill merged commit e224be2 into NixOS:staging Dec 29, 2018
@dtzWill dtzWill deleted the update/gnugrep-3.2 branch December 29, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants