Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argp-standalone: add x86_64-linux support #52589

Merged
merged 1 commit into from Apr 10, 2019
Merged

argp-standalone: add x86_64-linux support #52589

merged 1 commit into from Apr 10, 2019

Conversation

Amar1729
Copy link
Contributor

Motivation for this change

I submitted this package a while ago for macOS; this PR adds linux (testing on Ubuntu 18) functionality. Only testing with nix on Ubuntu and macOS so far but I think it should work on other linux flavors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested fixes have been made. Builds, no reverse dependencies.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@worldofpeace worldofpeace changed the title argp-standalone: 1.3 working for linux argp-standalone: add x86_64-linux support Apr 10, 2019
@worldofpeace
Copy link
Contributor

Just fixed up the git trivialities.

@worldofpeace worldofpeace merged commit 896c656 into NixOS:master Apr 10, 2019
@Amar1729 Amar1729 deleted the fix/argp-standalone branch April 10, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Amar1729 @nixos-discourse @worldofpeace @tomberek @GrahamcOfBorg