Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquibase: fix missing dependencies #52587

Merged
merged 1 commit into from Dec 21, 2018
Merged

liquibase: fix missing dependencies #52587

merged 1 commit into from Dec 21, 2018

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

This fixes #52561

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Dec 21, 2018

This PR fixes an actual problem, so I'm 👍 for merging now. As soon as there's a proper upstream fix we can still fix patch the expression.

@Ma27 Ma27 merged commit a2389cc into NixOS:master Dec 21, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 21, 2018

Backported as 948c9f4.

Thanks a lot for fixing! As soon as there's a proper fix we can still cleanup the expression IMHO :)

@pmiddend pmiddend deleted the liquibase-temporary-fix-jars branch December 21, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

liquibase fails: NoClassDefFoundError
3 participants
@pmiddend @Ma27 @GrahamcOfBorg