Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: cypari2: 1.3.1 -> 2.0.0" #52596

Merged
merged 1 commit into from Dec 20, 2018
Merged

Revert "python: cypari2: 1.3.1 -> 2.0.0" #52596

merged 1 commit into from Dec 20, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 20, 2018

Motivation for this change

This reverts commit 7c9ca65. The
cypari2 update is not ready. The package is pretty much only used for
sage and the update causes problems:
https://trac.sagemath.org/ticket/26442#comment:33
I've already reverted this once before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Revert "python: cypari2: 1.3.1 -> 2.0.0"
694b459 
This reverts commit 7c9ca65. The
cypari2 update is not ready. The package is pretty much only used for
sage and the update causes problems:
https://trac.sagemath.org/ticket/26442#comment:33
I've already reverted this once before.
@timokau timokau requested a review from FRidh as a code owner December 20, 2018 22:33
@timokau timokau merged commit 64b9df0 into NixOS:master Dec 20, 2018
@timokau timokau deleted the cypari2-revert2 branch December 20, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg