Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnused: 4.5 -> 4.7 #52576

Merged
merged 2 commits into from Dec 29, 2018
Merged

gnused: 4.5 -> 4.7 #52576

merged 2 commits into from Dec 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 20, 2018

https://savannah.gnu.org/forum/forum.php?forum_id=9331

Mirrors didn't seem to have it, hash obtained via

$ nix-prefetch-url https://ftp.gnu.org/gnu/sed/sed-4.6.tar.xz

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lsix lsix mentioned this pull request Dec 20, 2018
Closed
10 tasks
@dtzWill dtzWill changed the title gnused: 4.5 -> 4.6 gnused: 4.5 -> 4.7 Dec 21, 2018
@markuskowa
Copy link
Member

the two failed builds could not download the sources.
@GrahamcOfBorg build gnused

@markuskowa markuskowa mentioned this pull request Dec 22, 2018
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Dec 22, 2018

@GrahamcOfBorg build gnused

@dtzWill
Copy link
Member Author

dtzWill commented Dec 23, 2018

(timeout)

@jtojnar jtojnar mentioned this pull request Dec 24, 2018
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

Been working for me along with gnugrep bump; borg isn't as useful as usual here since this requires rebuilding bootstrap stages which takes too long.

@dtzWill dtzWill merged commit 8a72802 into NixOS:staging Dec 29, 2018
@dtzWill dtzWill deleted the update/sed-4.6 branch December 29, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @markuskowa @GrahamcOfBorg