Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoclue2: correct sysconfdir #52592

Merged
merged 1 commit into from Dec 26, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fix #52512

Things done

I've rebuilt my system with this commit and I no longer see:

 Failed to load configuration file 'etc/geoclue/geoclue.conf': No such file or directory

in the output of systemctl status geoclue.


cc @jtojnar @dtzWill

@matthewbauer
Copy link
Member

Shouldn't sysconfdir be /etc? Otherwise your configuration is read only.

@worldofpeace
Copy link
Contributor Author

We currently aren't modifying/generatating this config file with a NixOS module.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 21, 2018

Even if the NixOS module does not support configuration, users should still be able to use environment.etc.[…] option. Since patching it like fwupd is quite simple, I suggest we do that instead.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Dec 21, 2018

Even if the NixOS module does not support configuration, users should still be able to use environment.etc.[…] option. Since patching it like fwupd is quite simple, I suggest we do that instead.

Yes we can do that, but we'd also need to add

environment.etc."geoclue/geoclue.conf".source = "${pkgs.geoclue2}/etc/geoclue/geoclue.conf";

to the NixOS module.

Prior to the update to geoclue it was just reading the bundled config within its own prefix.

I actually wasn't going for an improvement like that, just restore how it was.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Dec 25, 2018

@jtojnar I integrated your change

@worldofpeace worldofpeace merged commit 3f6c81d into NixOS:master Dec 26, 2018
@worldofpeace worldofpeace deleted the geoclue/correct-sysconf branch December 26, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants