amazon-ecs-cli: init at 1.12.1 #52605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scriptkiddi
force-pushed
the
amazon-ecs-cli
branch
from
cd8de7a
to
2fadbe6
Compare
joachifm
reviewed
Dec 22, 2018
| sha256 = "100iv4cchnxl1s02higga5v3hvawi4c7sqva97x34qigr4r7fxwm"; | ||
| }; | ||
|
|
||
| unpackCmd = "mkdir bin; cp $src ./bin/ecs-cli"; |
There was a problem hiding this comment.
Seems to me that unpackCmd and installPhase can be replaced with
install -D $src $out/bin/ecs-cli
There was a problem hiding this comment.
I have not found a way to disable the unpack phase, could you point me in the right direction?
There was a problem hiding this comment.
A simple way to disable specific phases is to set them to ":", as in
{
unpackPhase = ":";
}There was a problem hiding this comment.
LGTM. Using install would shorten it further, as noted above. Even simpler would be
runCommand "foo" { src = fetchurl { /* ... */ }; } ''install -D $src $out/bin/foo''There may even be a suitable canned builder that captures this pattern entirely. That said I think what you have is acceptable as is ...
joachifm
reviewed
Dec 22, 2018
Scriptkiddi
force-pushed
the
amazon-ecs-cli
branch
from
2fadbe6
to
7ad77f8
Compare
Scriptkiddi
force-pushed
the
amazon-ecs-cli
branch
from
7ad77f8
to
8cb8b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
SInce we needed this for the deployment process I figured I push it upstream
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)