New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: get rid of libkrb5 in the darwin closure #52591
Conversation
There's a curlFull for cases where these extra features are required, curl is part of the darwin stdenv so most options should not be enabled there.
, scpSupport ? zlibSupport && !stdenv.isSunOS && !stdenv.isCygwin, libssh2 ? null | ||
, gssSupport ? !stdenv.hostPlatform.isWindows, libkrb5 ? null | ||
, scpSupport ? false, libssh2 ? null | ||
, gssSupport ? false, libkrb5 ? null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change this to !stdenv.isDarwin
if this is too controversial, but I personally don't think those should be enabled by default given that curlFull exists.
Are there any updates on this pull request, please? |
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
4 years old, closing. |
Motivation for this change
There's a curlFull for cases where these extra features are required,
curl is part of the darwin stdenv so most options should not be enabled
there.
/cc @NixOS/darwin-maintainers
Things done
sandbox
innix.conf
on non-NixOS)./result/bin/
)nix path-info -S
before and after)