Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyu2f: init at 0.1.4 #52590

Merged
merged 1 commit into from Jan 30, 2019
Merged

pythonPackages.pyu2f: init at 0.1.4 #52590

merged 1 commit into from Jan 30, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 20, 2018

Motivation for this change

This commit adds new package pyu2f which is very useful for people developing with U2F protocol.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from FRidh as a code owner December 20, 2018 20:31
worldofpeace
worldofpeace previously requested changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct commit msg would be:
python.pkgs.pyu2f: init at 0.1.4

Also a more common attribute used in python commit msg is pythonPackages instead of python.pkgs.

@prusnak
Copy link
Member Author

prusnak commented Dec 20, 2018 •
edited

Applied the requested changes in 24a75c7

@worldofpeace
Copy link
Contributor

@prusnak #52590 (comment) Still stands

@prusnak
Copy link
Member Author

prusnak commented Dec 21, 2018

Amended in c345b4c7da7f3ef763d8f13ad8b13b154002ff99

@worldofpeace
Copy link
Contributor

Amended in c345b4c

Great 👍

Would you mind posting the error when tests are enabled?
Usually we can skip a particular test or correct it.

@worldofpeace worldofpeace changed the title python.pkgs.pyu2f: new package (at version 0.1.4) pythonPackages.pyu2f: init at 0.1.4 Dec 21, 2018
@prusnak
Copy link
Member Author

prusnak commented Dec 21, 2018 

these derivations will be built:
  /nix/store/nmxiqzyxmryrpcqcba98p7dapcqdsfgc-python3.6-pyu2f-0.1.4.drv
building '/nix/store/nmxiqzyxmryrpcqcba98p7dapcqdsfgc-python3.6-pyu2f-0.1.4.drv'...
unpacking sources
unpacking source archive /nix/store/ngp7qg9fngfyr600nddfg19yzphlg52m-pyu2f-0.1.4.tar.gz
source root is pyu2f-0.1.4
setting SOURCE_DATE_EPOCH to timestamp 1524800303 of file pyu2f-0.1.4/setup.cfg
patching sources
configuring
building
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/pyu2f
copying pyu2f/model.py -> build/lib/pyu2f
copying pyu2f/errors.py -> build/lib/pyu2f
copying pyu2f/hidtransport.py -> build/lib/pyu2f
copying pyu2f/u2f.py -> build/lib/pyu2f
copying pyu2f/hardware.py -> build/lib/pyu2f
copying pyu2f/apdu.py -> build/lib/pyu2f
copying pyu2f/__init__.py -> build/lib/pyu2f
creating build/lib/pyu2f/convenience
copying pyu2f/convenience/baseauthenticator.py -> build/lib/pyu2f/convenience
copying pyu2f/convenience/customauthenticator.py -> build/lib/pyu2f/convenience
copying pyu2f/convenience/authenticator.py -> build/lib/pyu2f/convenience
copying pyu2f/convenience/localauthenticator.py -> build/lib/pyu2f/convenience
copying pyu2f/convenience/__init__.py -> build/lib/pyu2f/convenience
creating build/lib/pyu2f/hid
copying pyu2f/hid/base.py -> build/lib/pyu2f/hid
copying pyu2f/hid/macos.py -> build/lib/pyu2f/hid
copying pyu2f/hid/linux.py -> build/lib/pyu2f/hid
copying pyu2f/hid/try.py -> build/lib/pyu2f/hid
copying pyu2f/hid/__init__.py -> build/lib/pyu2f/hid
copying pyu2f/hid/windows.py -> build/lib/pyu2f/hid
running egg_info
writing pyu2f.egg-info/PKG-INFO
writing dependency_links to pyu2f.egg-info/dependency_links.txt
writing requirements to pyu2f.egg-info/requires.txt
writing top-level names to pyu2f.egg-info/top_level.txt
reading manifest file 'pyu2f.egg-info/SOURCES.txt'
writing manifest file 'pyu2f.egg-info/SOURCES.txt'
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/model.py -> build/bdist.linux-x86_64/wheel/pyu2f
creating build/bdist.linux-x86_64/wheel/pyu2f/convenience
copying build/lib/pyu2f/convenience/baseauthenticator.py -> build/bdist.linux-x86_64/wheel/pyu2f/convenience
copying build/lib/pyu2f/convenience/customauthenticator.py -> build/bdist.linux-x86_64/wheel/pyu2f/convenience
copying build/lib/pyu2f/convenience/authenticator.py -> build/bdist.linux-x86_64/wheel/pyu2f/convenience
copying build/lib/pyu2f/convenience/localauthenticator.py -> build/bdist.linux-x86_64/wheel/pyu2f/convenience
copying build/lib/pyu2f/convenience/__init__.py -> build/bdist.linux-x86_64/wheel/pyu2f/convenience
creating build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/base.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/macos.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/linux.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/try.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/__init__.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/hid/windows.py -> build/bdist.linux-x86_64/wheel/pyu2f/hid
copying build/lib/pyu2f/errors.py -> build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/hidtransport.py -> build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/u2f.py -> build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/hardware.py -> build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/apdu.py -> build/bdist.linux-x86_64/wheel/pyu2f
copying build/lib/pyu2f/__init__.py -> build/bdist.linux-x86_64/wheel/pyu2f
running install_egg_info
Copying pyu2f.egg-info to build/bdist.linux-x86_64/wheel/pyu2f-0.1.4-py3.6.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/pyu2f-0.1.4.dist-info/WHEEL
creating 'dist/pyu2f-0.1.4-py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
adding 'pyu2f/__init__.py'
adding 'pyu2f/apdu.py'
adding 'pyu2f/errors.py'
adding 'pyu2f/hardware.py'
adding 'pyu2f/hidtransport.py'
adding 'pyu2f/model.py'
adding 'pyu2f/u2f.py'
adding 'pyu2f/convenience/__init__.py'
adding 'pyu2f/convenience/authenticator.py'
adding 'pyu2f/convenience/baseauthenticator.py'
adding 'pyu2f/convenience/customauthenticator.py'
adding 'pyu2f/convenience/localauthenticator.py'
adding 'pyu2f/hid/__init__.py'
adding 'pyu2f/hid/base.py'
adding 'pyu2f/hid/linux.py'
adding 'pyu2f/hid/macos.py'
adding 'pyu2f/hid/try.py'
adding 'pyu2f/hid/windows.py'
adding 'pyu2f-0.1.4.dist-info/METADATA'
adding 'pyu2f-0.1.4.dist-info/WHEEL'
adding 'pyu2f-0.1.4.dist-info/top_level.txt'
adding 'pyu2f-0.1.4.dist-info/zip-safe'
adding 'pyu2f-0.1.4.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
installing
/build/pyu2f-0.1.4/dist /build/pyu2f-0.1.4
Processing ./pyu2f-0.1.4-py3-none-any.whl
Requirement already satisfied: six in /nix/store/b3qyac35llvrpc836zpjvvh85ckcf4lj-python3.6-six-1.11.0/lib/python3.6/site-packages (from pyu2f==0.1.4) (1.11.0)
Installing collected packages: pyu2f
Successfully installed pyu2f-0.1.4
/build/pyu2f-0.1.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mbvn1mgjr82mzjvvmpnl339553a33mmz-python3.6-pyu2f-0.1.4
strip is /nix/store/jdlb06c0kp6sms277xcclfr3gdl8pb9r-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mbvn1mgjr82mzjvvmpnl339553a33mmz-python3.6-pyu2f-0.1.4/lib
patching script interpreter paths in /nix/store/mbvn1mgjr82mzjvvmpnl339553a33mmz-python3.6-pyu2f-0.1.4
checking for references to /build/ in /nix/store/mbvn1mgjr82mzjvvmpnl339553a33mmz-python3.6-pyu2f-0.1.4...
running install tests
running test
running egg_info
writing pyu2f.egg-info/PKG-INFO
writing dependency_links to pyu2f.egg-info/dependency_links.txt
writing requirements to pyu2f.egg-info/requires.txt
writing top-level names to pyu2f.egg-info/top_level.txt
reading manifest file 'pyu2f.egg-info/SOURCES.txt'
writing manifest file 'pyu2f.egg-info/SOURCES.txt'
running build_ext
Not running on MacOS
Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 61, in <module>
    zip_safe=True,
  File "/nix/store/ng05zrzwdchk2mgq01bizyc3gj2zw6xk-python3.6-bootstrapped-pip-18.1/lib/python3.6/site-packages/setuptools/__init__.py", line 143, in setup
    return distutils.core.setup(**attrs)
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/distutils/dist.py", line 955, in run_commands
    self.run_command(cmd)
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/distutils/dist.py", line 974, in run_command
    cmd_obj.run()
  File "/nix/store/ng05zrzwdchk2mgq01bizyc3gj2zw6xk-python3.6-bootstrapped-pip-18.1/lib/python3.6/site-packages/setuptools/command/test.py", line 228, in run
    self.run_tests()
  File "/nix/store/ng05zrzwdchk2mgq01bizyc3gj2zw6xk-python3.6-bootstrapped-pip-18.1/lib/python3.6/site-packages/setuptools/command/test.py", line 250, in run_tests
    exit=False,
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/main.py", line 118, in parseArgs
    self._do_discovery(argv[2:])
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/main.py", line 229, in _do_discovery
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/loader.py", line 341, in discover
    tests = list(self._find_tests(start_dir, pattern))
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/loader.py", line 398, in _find_tests
    full_path, pattern, namespace)
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/loader.py", line 475, in _find_test_path
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File "/nix/store/ng05zrzwdchk2mgq01bizyc3gj2zw6xk-python3.6-bootstrapped-pip-18.1/lib/python3.6/site-packages/setuptools/command/test.py", line 54, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/loader.py", line 190, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "/nix/store/ng05zrzwdchk2mgq01bizyc3gj2zw6xk-python3.6-bootstrapped-pip-18.1/lib/python3.6/site-packages/setuptools/command/test.py", line 54, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/build/pyu2f-0.1.4/pyu2f/hid/windows.py", line 18, in <module>
    from ctypes import wintypes
  File "/nix/store/gawjnyhb54aq4qby8vk9glh3pn1iyaqn-python3-3.6.7/lib/python3.6/ctypes/wintypes.py", line 20, in <module>
    class VARIANT_BOOL(ctypes._SimpleCData):
ValueError: _type_ 'v' not supported
builder for '/nix/store/nmxiqzyxmryrpcqcba98p7dapcqdsfgc-python3.6-pyu2f-0.1.4.drv' failed with exit code 1
error: build of '/nix/store/nmxiqzyxmryrpcqcba98p7dapcqdsfgc-python3.6-pyu2f-0.1.4.drv' failed

@prusnak
Copy link
Member Author

prusnak commented Jan 6, 2019

@worldofpeace do you want to have a look at the failure or we keep the check disabled?

@prusnak
Copy link
Member Author

prusnak commented Jan 30, 2019

@FRidh All comments were addressed except for enabling the tests (which seem broken somehow). Any ideas? Or we'll merge this w/o the tests?

@infinisil
Copy link
Member

Have you tested the package a bit yourself? If so, I think it's fine to merge without tests enabled.

@prusnak
Copy link
Member Author

prusnak commented Jan 30, 2019

@infinisil yes, I did.

@worldofpeace
Copy link
Contributor

I think we should just go for it then 😄
My apologies for forgetting about this @prusnak.

@GrahamcOfBorg build pythonPackages.pyu2f python3Packages.pyu2f python36Packages.pyu2f

@worldofpeace worldofpeace dismissed their stale review January 30, 2019 23:03

Resolved by author

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.pyu2f python3Packages.pyu2f python36Packages.pyu2f

@worldofpeace
Copy link
Contributor

Wait I can rerun those now 😆

@worldofpeace worldofpeace merged commit 344b340 into NixOS:master Jan 30, 2019
@prusnak prusnak deleted the pyu2f branch January 31, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @worldofpeace @infinisil @GrahamcOfBorg