Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocryptfs: 1.5 -> 1.6.1 #54366

Merged
merged 1 commit into from Jan 23, 2019
Merged

gocryptfs: 1.5 -> 1.6.1 #54366

merged 1 commit into from Jan 23, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Package update. Note the deps.nix was built with a patched version of dep2nix (nixcloud/dep2nix#15).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace reviewed Jan 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing mentions of trezor support in the changelog.
This should be enabled and maybe made optional.

@thefloweringash
Copy link
Member Author

Initial attempts to get the trezor support running are resulting in:

$ gocryptfs -init -trezor ~/.keys
Choose a password for protecting your files.
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x7fa394178ab4]

runtime stack:
runtime.throw(0x7f37fe, 0x2a)
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/panic.go:608 +0x72
runtime.sigpanic()
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/signal_unix.go:374 +0x2f2

goroutine 1 [syscall]:
runtime.cgocall(0x71b5f0, 0xc000105768, 0xc0001057a8)
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/cgocall.go:128 +0x5e fp=0xc000105738 sp=0xc000105700 pc=0x40a33e
github.com/xaionaro-go/cryptoWallet/vendor/github.com/trezor/trezord-go/usb/lowlevel._Cfunc_libusb_get_device_list(0x0, 0xc00000e0e0, 0x0)
	_cgo_gotypes.go:1146 +0x4e fp=0xc000105768 sp=0xc000105738 pc=0x66657e
github.com/xaionaro-go/cryptoWallet/vendor/github.com/trezor/trezord-go/usb/lowlevel.Get_Device_List.func1(0x0, 0xc00000e0e0, 0x66566c)
	/build/go/src/github.com/xaionaro-go/cryptoWallet/vendor/github.com/trezor/trezord-go/usb/lowlevel/libusb.go:885 +0x8f fp=0xc0001057a0 sp=0xc000105768 pc=0x66bdcf
github.com/xaionaro-go/cryptoWallet/vendor/github.com/trezor/trezord-go/usb/lowlevel.Get_Device_List(0x0, 0xc000011680, 0xc00010583e, 0xc000080680, 0xc000105890, 0x100000000000003)
	/build/go/src/github.com/xaionaro-go/cryptoWallet/vendor/github.com/trezor/trezord-go/usb/lowlevel/libusb.go:885 +0x49 fp=0xc0001057f0 sp=0xc0001057a0 pc=0x66b0f9
github.com/xaionaro-go/cryptoWallet.Find(0xc000014440, 0xc000014442, 0x1, 0x1, 0x0, 0xc000105940, 0x20)
	/build/go/src/github.com/xaionaro-go/cryptoWallet/find_linux.go:43 +0x3b4 fp=0xc0001058c0 sp=0xc0001057f0 pc=0x6b0874
github.com/rfjakob/gocryptfs/internal/readpassword.Trezor(0xc000018300, 0x20, 0x20, 0x20, 0x0, 0x0)
	/build/go/src/github.com/rfjakob/gocryptfs/internal/readpassword/trezor.go:47 +0xd9 fp=0xc000105a38 sp=0xc0001058c0 pc=0x6b23b9
main.initDir(0xc000120000)
	/build/go/src/github.com/rfjakob/gocryptfs/init_dir.go:78 +0xdd fp=0xc000105bd0 sp=0xc000105a38 pc=0x70501d
main.main()
	/build/go/src/github.com/rfjakob/gocryptfs/main.go:317 +0x689 fp=0xc000105f98 sp=0xc000105bd0 pc=0x706e89
runtime.main()
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/proc.go:201 +0x207 fp=0xc000105fe0 sp=0xc000105f98 pc=0x4345a7
runtime.goexit()
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/asm_amd64.s:1333 +0x1 fp=0xc000105fe8 sp=0xc000105fe0 pc=0x462241

goroutine 5 [chan send]:
github.com/rfjakob/gocryptfs/internal/cryptocore.(*randPrefetcherT).refillWorker(0xd09c00)
	/build/go/src/github.com/rfjakob/gocryptfs/internal/cryptocore/randprefetch.go:51 +0x64
created by github.com/rfjakob/gocryptfs/internal/cryptocore.init.0
	/build/go/src/github.com/rfjakob/gocryptfs/internal/cryptocore/randprefetch.go:16 +0x6f

goroutine 6 [syscall]:
os/signal.signal_recv(0x0)
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/runtime/sigqueue.go:139 +0x9c
os/signal.loop()
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/os/signal/signal_unix.go:23 +0x22
created by os/signal.init.0
	/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.11.4/share/go/src/os/signal/signal_unix.go:29 +0x41

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build gocryptfs

@worldofpeace worldofpeace merged commit 3bb9b10 into NixOS:master Jan 23, 2019
@thefloweringash thefloweringash deleted the gocryptfs-update branch May 1, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @worldofpeace @GrahamcOfBorg