Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.django_reversion: disable checks #54379

Merged
merged 1 commit into from Jan 21, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 20, 2019

Motivation for this change

These weren't running properly anyway - they assume the availability of a mysql and/or postgresql database. Disabling them should stop them causing trouble. I've made a small suggestion to the author of how they could make their tests more friendly to us: etianen/django-reversion#773

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner January 20, 2019 17:22
these weren't running properly anyway - they assume the availability of a
mysql and/or postgresql database
@dotlambda

This comment has been minimized.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.django_reversion python3.pkgs.django_reversion

@dotlambda dotlambda merged commit de3b2d1 into NixOS:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants