Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: fix plugin detection #54340

Merged
merged 1 commit into from Mar 9, 2019
Merged

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 19, 2019

Motivation for this change

The --suffix option escapes it's arguments since #31497. This leads to the
GST_PLUGIN_SYTEM_PATH variable to be not correctly expanded with the embedded
bash script.

Switching to --run and crafting the required export by hand bypasses the issue.

Closes #10559

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The `--suffix` option escapes it's arguments. This leads to the
`GST_PLUGIN_SYTEM_PATH` variable to be not correctly expanded with the embedded
bash script.

Switching to `--run` and crafting the required export by hand bypasses the issue.
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produces the intended effect 👍

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to staging because of the rebuilds.

@bachp
Copy link
Member Author

bachp commented Mar 6, 2019

@worldofpeace I never worked with staging. What do I need to do? Do the PR against staging instead of master?

@hedning
Copy link
Contributor

hedning commented Mar 6, 2019

You can change the target branch when editing the title.

Edit: should go against the staging branch.

@bachp bachp changed the base branch from master to staging March 6, 2019 15:43
@bachp
Copy link
Member Author

bachp commented Mar 6, 2019

@hedning Thanks for clarifying. I did change the target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants