Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: reduce closure size #54335

Merged
merged 1 commit into from Jan 20, 2019
Merged

kubectl: reduce closure size #54335

merged 1 commit into from Jan 20, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 19, 2019 •
edited

before: 482M
after: 38M

Motivation for this change

the closure size is too big

maintainers: @johanot @offlinehacker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
kubectl: reduce closure size
556c442 
before: 482M
after: 38M
@domenkozar domenkozar merged commit 555e7eb into NixOS:master Jan 20, 2019
@zimbatm zimbatm deleted the kubectl-small branch January 20, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @domenkozar @GrahamcOfBorg