Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eclipses: 4.9 -> 4.10 #54390

Merged
merged 1 commit into from Jan 21, 2019
Merged

eclipses: 4.9 -> 4.10 #54390

merged 1 commit into from Jan 21, 2019

Conversation

rycee
Copy link
Member

@rycee rycee commented Jan 20, 2019

This applies to Eclipse platform, SDK, and the JDT plugin.

@rycee
eclipses: 4.9 -> 4.10
08bf731 
This applies to Eclipse platform, SDK, and the JDT plugin.
@rycee rycee self-assigned this Jan 20, 2019
@rycee rycee closed this Jan 20, 2019
@rycee rycee deleted the bump/eclipse branch January 20, 2019 23:57
@rycee rycee merged commit 08bf731 into NixOS:master Jan 21, 2019
@samueldr
Copy link
Member

Heads up, this broke nixpgks.tarball due to the missing i686-linux source, which isn't available upstream.

checking Nixpkgs on i686-linux
error: while querying the derivation named 'eclipse-platform-4.10':
while evaluating the attribute 'src' of the derivation 'eclipse-platform-4.10' at /build/source/pkgs/stdenv/generic/make-derivation.nix:185:11:
attribute 'i686-linux' missing, at /build/source/pkgs/applications/editors/eclipse/build-eclipse.nix:5:15
build time elapsed:  0m0.107s 0m0.127s 0m19.143s 0m2.722s

I do not know how to fix it properly; it looks like it would need to be fixed in pkgs/applications/editors/eclipse/build-eclipse.nix to somehow do the right thing when there's no source available.

rycee added a commit to rycee/nixpkgs that referenced this pull request Jan 21, 2019
@rycee
Revert "eclipses: 4.9 -> 4.10"
c076bd2 
This reverts commit 08bf731.

See NixOS#54390 (comment)
@rycee
Copy link
Member Author

rycee commented Jan 21, 2019

Sorry, reverted in c076bd2.

@jerith666
Copy link
Contributor

it looks like eclipse stopped supporting 32-bit in 2018-12. I'm working on redoing this with that in mind.

@jerith666
Copy link
Contributor

See #55575 for my attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rycee rycee

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rycee @samueldr @jerith666 @GrahamcOfBorg