New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: support binary distribution via our new infrastructure #23
Conversation
Would benefit from link validation. |
Binaries are uploaded to a CDN. listing.txt and latest.txt help navigate the CDN. Currently both infrastructures are supported. We will slowly migrate everything to the new infrastructure, once everything is live and in working order.
--- | ||
|
||
For OpenTTD you can use the original Transport Tycoon Deluxe data files (you need to own a Transport Tycoon Deluxe CD). | ||
There are also the free alternatives: [OpenGFX (graphics)](http://dev.openttdcoop.org/projects/opengfx), [OpenSFX (sound)](http://dev.openttdcoop.org/projects/opensfx), and [OpenMSX (music)](http://dev.openttdcoop.org/projects/openmsx). | ||
These can be installed automatically by the Windows and OS/2 installers. | ||
Please refer to the [readme](https://binaries.openttd.org/nightlies/trunk/@@version@@/readme.txt) for more information. | ||
Please refer to the [readme](https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/@@version@@/README.md) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it's likely to change at some point, perhaps putting the URL in a variable somewhere might be appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; more of these need attention, as too many things are hardcoded. But I have yet to find a way to make this easier to template (I now wrote a custom 'template engine', that replaces @@Version@@). So I am going to create an issue out of this.
@@ -1,3 +1,3 @@ | |||
--- | |||
folder: extra/catcodec | |||
folder_old_infrastructure: extra/catcodec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you get around to making a readme, I'd recommend a list of all the "custom" variables (and what they're for)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are temporary during migration, but I agree. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this on 'works for me' basis. I ran a link checker over it, no 404s, only 200s, 301s, 302s, 307s, assuming they're all as expected.
WAVE toolbar reports multiple accessibility errors on the downloads page. They're pre-existing, I'll file an issue or PR for those separately.
Binaries are uploaded to a CDN. listing.txt and latest.txt help
navigate the CDN.
Currently both infrastructures are supported. We will slowly
migrate everything to the new infrastructure, once everything is
live and in working order.