Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-lua: init at 1.7.0 #54343

Merged
merged 1 commit into from Apr 27, 2019
Merged

z-lua: init at 1.7.0 #54343

merged 1 commit into from Apr 27, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 19, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/misc/z-lua/default.nix Outdated Show resolved Hide resolved
buildInputs = [ lua ];

postPatch = ''
patchShebangs z.lua
Copy link
Member

@Mic92 Mic92 Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This usually happens automatically in fixupPhase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks!

@Lassulus
Copy link
Member

Thanks for the PR and sorry for the delay!
seems like there is a 1.6.0 now. Would be very cool if you could update it :)

@marsam
Copy link
Contributor Author

marsam commented Apr 27, 2019

no worries, updated :)

@Lassulus Lassulus changed the title z-lua: init at 2019-01-19 z-lua: init at 1.7.0 Apr 27, 2019
@Lassulus Lassulus merged commit 1839b54 into NixOS:master Apr 27, 2019
@marsam marsam deleted the init-z-lua branch April 27, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants