Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pb cli and capture initialization #54349

Merged
merged 2 commits into from Jan 20, 2019
Merged

Pb cli and capture initialization #54349

merged 2 commits into from Jan 20, 2019

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Jan 20, 2019

Motivation for this change

pb is a fantastic pastebin service with a nice client, and it optionally depends on capture, which is a fantastic screen cap tool that uses ffmpeg. I use both of these at least every week and thought it'd be a nice addition.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

meta = with stdenv.lib; {
description = "A no bullshit screen capture tool";
homepage = "https://github.com/buhman/capture";
maintainers = [ maintainers.ar1a ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a license https://search.nix.gsc.io/?q=license%20%3D&i=nope&files=&repos= (same with the other package.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither packages have licenses, and as far as i could tell the default license is unfree - which would be accurate here i think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'm not sure we can really package software which isn't licensed... Maybe you're right, though. Can you open issues on those repos and ask them to apply a license?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptpb/pb_cli#12 buhman/capture#6

I thought we could package unfree software, for example discord or spotify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure we can, but they have a license saying they're unfree... but unlicensed is much less clear about rights, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure, i would argue that they just forgot to license the code especially because its advertised https://ptpb.pw/#shell-functions here but obviously that wouldn't really hold up. is there anyone you can ping who knows more about this stuff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the GitHub TOS changed to grant some basic licenses, but it turns out to be much more minimal than I expected:

If you publish your source code in a public repository on GitHub, according to the Terms of Service, other GitHub users have the right to view and fork your repository within the GitHub site.

I don't know ... I think there isn't a strict policy around requiring a license for Nixpkgs inclusion, but it sure seems there should be one ;)

I won't block on this problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i explicitly set it to unfree for the meantime then or just leave it omitted

patchShebangs $out/bin/capture
wrapProgram $out/bin/capture \
--prefix PATH : '${stdenv.lib.makeBinPath [ slop ffmpeg ]}'
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the text between '' quotes two spaces (same on the other package).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the patching and wrapping before the install call, ideally within the buildPhase.

@grahamc
Copy link
Member

grahamc commented Jan 20, 2019

@GrahamcOfBorg build pb_cli capture

@grahamc
Copy link
Member

grahamc commented Jan 20, 2019

@GrahamcOfBorg build pb_cli capture

@grahamc grahamc merged commit 44cd0a3 into NixOS:master Jan 20, 2019
@grahamc
Copy link
Member

grahamc commented Jan 20, 2019

Dang, forgot for ofborg to finish.

@ar1a
Copy link
Contributor Author

ar1a commented Mar 9, 2019

ptpb/pb#246 rip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants