Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add ssh backdoor to VM tests infrastructure." #54330

Merged
merged 1 commit into from Jan 19, 2019

Conversation

samueldr
Copy link
Member

This reverts commit d6e3db4.

See #53935 for explanations. In short, it may be causing issues with
tests on the build infrastructure.

This reverts commit d6e3db4.

See NixOS#53935 for explanations. In short, it may be causing issues with
tests on the build infrastructure.
@samueldr
Copy link
Member Author

@GrahamcOfBorg test login installer.simpleUefiSystemdBoot

@samueldr
Copy link
Member Author

Hmm, I was under the impression that the issue with tests was fixed. Let's do it the workaround way for now.

@GrahamcOfBorg build nixosTests.login

@samueldr
Copy link
Member Author

Welp, the combination of (1) master having things to build (2) builders having misc. issues makes the ofborg tests inconclusive. I can vouch that the [login installer.simpleUefiSystemdBoot] tests were fine locally, just as they were with the developer serial console access enabled.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can re-revert if we still see the timeouts.

@samueldr samueldr merged commit 50555a6 into NixOS:master Jan 19, 2019
@timokau
Copy link
Member

timokau commented Jan 20, 2019

Its a bit early to tell, but this looks very good: https://hydra.nixos.org/job/nixos/unstable-small/tested#tabs-constituents

@samueldr samueldr deleted the fix/disable-tests-shell-access branch February 12, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants