Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix megaparsec_6_5_0 and idris build #54331

Merged
merged 2 commits into from Jan 20, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

Closes #53406, continuation of #54006

When idris gets updated, this isn't needed anymore because of idris-lang/Idris-dev#4610

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Only the tests were incompatible with GHC 8.0's MonadFail change.
Patching would be possible too, but just not doing the tests is simpler.
@infinisil
Copy link
Member Author

@GrahamcOfBorg build idris

@domenkozar domenkozar merged commit 3600e0a into NixOS:haskell-updates Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants