Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6583: Rework Tileheight handling (patch by adf88) #7061

Merged
merged 6 commits into from Jan 24, 2019
Merged

Fix #6583: Rework Tileheight handling (patch by adf88) #7061

merged 6 commits into from Jan 24, 2019

Conversation

Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Jan 13, 2019 •
edited

Turned FS patch into a PR
had minor conflicts in comments

LordAro
LordAro approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything obviously wrong with the code, and works well in test - definitely fixes the bouncing along the bottom of the map issue

@andythenorth andythenorth mentioned this pull request Jan 24, 2019
Closed
@nielsmh nielsmh merged commit 479f13f into OpenTTD:master Jan 24, 2019
@nielsmh nielsmh mentioned this pull request Jan 25, 2019
Closed
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Jan 25, 2019
@PeterN
Fix OpenTTD#7098, OpenTTD#7061: Inverted test led to invalid iterator…
a88c796 
… access.
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Jan 25, 2019
@PeterN
Fix OpenTTD#7098, Fix OpenTTD#7061: Inverted test led to invalid iter…
5b85185 
…ator access.
LordAro pushed a commit that referenced this pull request Jan 26, 2019
@PeterN @LordAro
Fix #7098, Fix #7061: Inverted test led to invalid iterator access.
b6de8c0
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
@PeterN @nielsmh
Fix OpenTTD#7098, Fix OpenTTD#7061: Inverted test led to invalid iter…
81d1792 
…ator access.
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
@PeterN @douiwby
Fix OpenTTD#7098, Fix OpenTTD#7061: Inverted test led to invalid iter…
34282c1 
…ator access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eddi-z @LordAro @nielsmh