Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: patch missing mimetype database #54377

Merged
merged 1 commit into from Jan 24, 2019
Merged

go: patch missing mimetype database #54377

merged 1 commit into from Jan 24, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 20, 2019 •
edited

Motivation for this change

Close #53550

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s)
  • Tested compilation of all pkgs that depend on this change (only go-ipfs, too many)
  • Tested execution of all binary files (go-ipfs)
  • Determined the impact on package closure size (negligible)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil merged commit 1b998ce into NixOS:master Jan 24, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 24, 2019

Thank you

@rnhmjoj rnhmjoj deleted the go-mime branch February 23, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @infinisil @GrahamcOfBorg