Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acts: init at 1.3 #54381

Closed
wants to merge 3 commits into from
Closed

acts: init at 1.3 #54381

wants to merge 3 commits into from

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jan 20, 2019

Motivation for this change

An alternative to tarsnapper and the NixOS module.

It uses logger, does it mean I need to be declared a runtime dependency to utilLinuxMinimal, or is it somehow already included on all Linux builds?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric
Copy link
Contributor Author

Also, not sure how to deal with configuration, since the paths are hardcoded to /etc/acts.conf and /usr/local/etc/acts.conf.

@Lassulus
Copy link
Member

I would test this after the merge conflict is fixed.

@asymmetric
Copy link
Contributor Author

@Lassulus conflicts fixed.

I'm still unsure if this warrants a NixOS module, with config file generation, or if it the package is enough for now, and we can expect users to add a file to /etc/acts.conf manually.

@Lassulus
Copy link
Member

Lassulus commented May 27, 2019

It seems to get the config also from the current working directory (CWD) so I guess a package is sufficient for now. But if you want to also add a service, I won't stop you :)

Edit: I tested it, if you fix the 2 minor syntax things I will merge it

@Lassulus
Copy link
Member

whupps, somehow missed the updates, still good for merge?

@asymmetric
Copy link
Contributor Author

@Lassulus please hold off on merging, this could be made to use DynamicUser, LogsDirectory etc.

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asymmetric wants to update this to use DynamicUser

@stale
Copy link

stale bot commented Jul 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 3, 2020
@asymmetric
Copy link
Contributor Author

Not using this at the moment.

@asymmetric asymmetric closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants