Fix: Round up deltas for smooth scrolling, so that target will eventually be reached #7040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When smooth scrolling is enabled, the original code rounds the deltas toward zero. This means that the scroll position will never actually reach the destination scroll position (when the difference is 3, there will be no more scrolling in the original code). Rounding away from zero fixes this problem.
This bug also causes the cargo flow legend overlay to not be redrawn when smooth scrolling is enabled, because variable
update_overlay
in functionUpdateViewportPosition
never becomestrue
.To observe the bug in the original code: