pythonPackages.PyChromecast: 2.3.0 -> 2.4.0 #54361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Jan 20, 2019
|
|
||
| buildPythonPackage rec { | ||
| pname = "PyChromecast"; | ||
| version = "2.3.0"; | ||
| version = "2.4.0"; | ||
| name = pname + "-" + version; |
|
|
||
| buildPythonPackage rec { | ||
| pname = "PyChromecast"; | ||
| version = "2.3.0"; | ||
| version = "2.4.0"; | ||
| name = pname + "-" + version; | ||
|
|
||
| src = fetchurl { |
| }; | ||
|
|
||
| disabled = !isPy3k; | ||
|
|
||
| propagatedBuildInputs = [ requests six zeroconf protobuf casttube ]; |
There was a problem hiding this comment.
six is no longer required since home-assistant-libs/pychromecast@c15d23e
dotlambda
changed the title
also py2 support was dropped in 2.0 (apparently)
dtzWill
force-pushed
the
update/pychromecast-2.4.0
branch
from
d95f03f
to
fd43726
Compare
|
Pushed commit making these changes, thanks!
(and sorry for being lazy about such cleanup initially :3)
Only caveat is commit is updated to have different capitalization,
in order to match the attribute name which I think was intended anyway.
Perhaps it doesn't "matter" but would it make sense for this
to instead refer to `python3Packages.PyChromecast` since
it doesn't work with py2?
…On Sun, 20 Jan 2019 02:31:04 -0800, Robert Schütz ***@***.***> wrote:
dotlambda requested changes on this pull request.
The commit message should be `pythonPackages.pychromecast: 2.3.0 -> 2.4.0`
>
buildPythonPackage rec {
pname = "PyChromecast";
- version = "2.3.0";
+ version = "2.4.0";
name = pname + "-" + version;
Remove this line.
>
buildPythonPackage rec {
pname = "PyChromecast";
- version = "2.3.0";
+ version = "2.4.0";
name = pname + "-" + version;
src = fetchurl {
`fetchPypi`
> };
+ disabled = !isPy3k;
+
propagatedBuildInputs = [ requests six zeroconf protobuf casttube ];
`six` is no longer required since home-assistant-libs/pychromecast@c15d23e
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#54361 (review) part: text/html
|
I think that's not of great importance. Both is ok. |
|
@GrahamcOfBorg build python3.pkgs.PyChromecast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also py2 support was dropped in 2.0 (apparently)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)