-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.PyChromecast: 2.3.0 -> 2.4.0 #54361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should be pythonPackages.PyChromecast: 2.3.0 -> 2.4.0
|
||
buildPythonPackage rec { | ||
pname = "PyChromecast"; | ||
version = "2.3.0"; | ||
version = "2.4.0"; | ||
name = pname + "-" + version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
|
||
buildPythonPackage rec { | ||
pname = "PyChromecast"; | ||
version = "2.3.0"; | ||
version = "2.4.0"; | ||
name = pname + "-" + version; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi
}; | ||
|
||
disabled = !isPy3k; | ||
|
||
propagatedBuildInputs = [ requests six zeroconf protobuf casttube ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
six
is no longer required since home-assistant-libs/pychromecast@c15d23e
also py2 support was dropped in 2.0 (apparently)
d95f03f
to
fd43726
Compare
Pushed commit making these changes, thanks!
(and sorry for being lazy about such cleanup initially :3)
Only caveat is commit is updated to have different capitalization,
in order to match the attribute name which I think was intended anyway.
Perhaps it doesn't "matter" but would it make sense for this
to instead refer to `python3Packages.PyChromecast` since
it doesn't work with py2?
…On Sun, 20 Jan 2019 02:31:04 -0800, Robert Schütz ***@***.***> wrote:
dotlambda requested changes on this pull request.
The commit message should be `pythonPackages.pychromecast: 2.3.0 -> 2.4.0`
>
buildPythonPackage rec {
pname = "PyChromecast";
- version = "2.3.0";
+ version = "2.4.0";
name = pname + "-" + version;
Remove this line.
>
buildPythonPackage rec {
pname = "PyChromecast";
- version = "2.3.0";
+ version = "2.4.0";
name = pname + "-" + version;
src = fetchurl {
`fetchPypi`
> };
+ disabled = !isPy3k;
+
propagatedBuildInputs = [ requests six zeroconf protobuf casttube ];
`six` is no longer required since home-assistant-libs/pychromecast@c15d23e
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#54361 (review) part: text/html
|
I think that's not of great importance. Both is ok. |
@GrahamcOfBorg build python3.pkgs.PyChromecast |
also py2 support was dropped in 2.0 (apparently)
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)