Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonttools: 3.34.2 -> 3.35.2 #54362

Closed
wants to merge 1 commit into from
Closed

fonttools: 3.34.2 -> 3.35.2 #54362

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 20, 2019

Motivation for this change
Things done

(but not on this exact branch, FWIW)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner January 20, 2019 08:06
worldofpeace
worldofpeace suggested changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit msg should be pythonPackages.fonttools: 3.34.2 -> 3.35.2

Also I don't see a need for this to got to staging.

@dtzWill dtzWill changed the base branch from staging to master January 21, 2019 00:45
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.fonttools python3Packages.fonttools

@dtzWill
Copy link
Member Author

dtzWill commented Jan 29, 2019

Looks like I was too slow and it was updated to newer version in the meantime! haha oops :D.

@dtzWill dtzWill closed this Jan 29, 2019
@dtzWill dtzWill deleted the update/fonttools-3.35.2 branch January 29, 2019 03:28
@dtzWill dtzWill mentioned this pull request Jan 29, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @GrahamcOfBorg