New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qrencode: merge with libqrencode #53149
Conversation
Hmm, @Ma27 was faster. |
Apparently, the tests do not run in |
Looks great to me, thanks! |
testHaskellDepends = [ base hspec ]; | ||
description = "Library to generate images"; | ||
license = stdenv.lib.licenses.bsd3; | ||
hydraPlatforms = stdenv.lib.platforms.none; | ||
}) {inherit (pkgs) libqrencode;}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that pkgs/development/haskell-modules/hackage-packages.nix
shouldn't be edited by hand. This seems to me like it will break the qr-imager
Haskell package the next time @peti runs hackage2nix
(which happens more-or-less weekly?).
I think an issue should be created on https://github.com/NixOS/cabal2nix that aliases libqrencode
to qrencode
.
Here's the cabal file in question that is specifically checking for libqrencode
:
http://hackage.haskell.org/package/qr-imager-2.0.0.2/src/qr-imager.cabal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that cabal2nix finds the correct package through https://github.com/peti/distribution-nixpkgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, thanks for the info @jtojnar, I didn't know about https://github.com/peti/distribution-nixpkgs!
Motivation for this change
Closes: #53133
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @jameysharp @yegortimoshenko @adolfogc