Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libqrencode: alias to pkgs.qrencode. #53148

Closed
wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 1, 2019

Motivation for this change

The packages were almost equal, used the same major version and referred
to the same source without specifying custom build arguments in one of
each.

I decided to keep qrencode by default as the lib prefix may be
confusing as it wrongly indicates that only libraries are provided by
the package, but bin/qrencode is packaged in both of them.

Fixes #53133

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The packages were almost equal, used the same major version and referred
to the same source without specifying custom build arguments in one of
each.

I decided to keep `qrencode` by default as the `lib` prefix may be
confusing as it wrongly indicates that only libraries are provided by
the package, but `bin/qrencode` is packaged in both of them.

Fixes NixOS#53133
@Ma27
Copy link
Member Author

Ma27 commented Jan 1, 2019

pinging @adolfogc, the maintainer of libqrencode.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 1, 2019

Aliases cannot be used in nixpkgs.

Alternative PR which takes care of this plus some extra bells and whistles: #53149

@Ma27
Copy link
Member Author

Ma27 commented Jan 2, 2019

ack, let's use your patch then :)

@Ma27 Ma27 closed this Jan 2, 2019
@Ma27 Ma27 deleted the merge-qrencode-libqrencode branch January 2, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qrencode is packaged twice
2 participants