New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualbox: 5.2.28 -> 6.0.6 #53120
virtualbox: 5.2.28 -> 6.0.6 #53120
Conversation
6287cc6
to
18bc1ea
Compare
18bc1ea
to
1c6f566
Compare
Does 3D Accel work again with this version of VBox? Does anyone know? |
I've tested this PR on my machine, after upgrading to It doesn't seem to find its extension pack (installed in libexec due to a non-hardened build) It does work on linux 4.20, though, which is an improvement over vbox 5 ;) |
1c6f566
to
4e880a4
Compare
I removed the WIP status, but I couldn't get the tests to work. Everything else should work, including 3D accel. |
4e880a4
to
e0e27ef
Compare
What's blocking this? |
I tried it, it works on my side. @infinisil I'd like to merge this if it's alright with you. |
I see three open questions:
- hardening
- extension pack
- nixos tests
I'm not entirely against merging this while these don't work yet (it doesn't currently build with linuxPackages_latest at all), but we should still pick this up :-)
|
Please merge #55596 before or with this merge as that PR implies that this would break vagrant since the current version in unstable doesn't support virtualbox 6. |
@wkral thank you for letting me know, I will merge #55596 after this one. @flokli Let's wait to hear from @infinisil in this case! |
@flokli As far I can tell, hardening and extension pack work. I wasn't able to get the NixOS tests to run and fixing them is beyond my abilities. |
@aszlig do you have time to dig into the virtualbox tests? |
f9d2098
to
ecb2bb4
Compare
I'm happy to test this on macOS, although I'm a bit new to Nix. Can someone guide me on the appropriate process to check this out, and test it? |
I've created a Darwin specific package, here what-the-functor@d0d87fc |
@tonylotts I don't think virtualbox 6.0.4 completly broken for linux, it's just that the nixos vm tests don't work anymore (maybe due to the nested virtualization happening here) so we don't spot things suddenly breaking, which is why I'm hesitant to bump it without fixing the tests too… Note the darwin-specific |
@flokli, yes I've purposely used the pre-built binary; although I acknowledge that the community preference is to build from source. As I understand it, pre-built binaries are cached. In the case that VirtualBox is already available in pre-built form, can/should that be cached? |
Even when there's a from-source build in nixpkgs, it should be built by Hydra and available from cache.nixos.org.
This currently isn't working for virtual box with extension pack enabled, as IIRC its license forbids redistribution of the extpack itself, but for the non-extpack variant it should be in the cache.
|
Got it. |
It turns out that the macOS version of VirtualBox provides kernel extensions. A macOS derivation for VirtualBox would require nix-darwin, and support for kernel extensions LnL7/nix-darwin#91. |
@tonylotts so no matter what variant we use, the darwin version depends on LnL7/nix-darwin#91 or a successor to be merged? |
6.0.6 has been released. Not that it matters that much, I guess, right now. |
@flokli, yes |
@devhell I tried bumping to 6.0.6, but it seems some patches need to be adjusted. Did you do that already somewhere? |
The release notes mention some nested (AMD) virtualization fixes - I guess we still should see if things have improved. |
@flokli I've not been able to, no. Sorry. :/ |
@ptrhlm could you get to that? |
@flokli I've removed unnecessary kernel module patches. Also, I've moved patching of kernel module sources to the main package, so now unaligned patch will fail earlier. Tests still fail on my Intel machine. |
@ptrhlm thanks for the cleanup! I gave the tests a try on an AMD machine too, unfortunately, they fail there, too:
|
closed in favour of #60943. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Things to do
Build with hardening doesn't start