Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: 5.2.28 -> 6.0.6 #53120

Closed
wants to merge 1 commit into from
Closed

Conversation

ptrhlm
Copy link
Contributor

@ptrhlm ptrhlm commented Dec 31, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Things to do
  • Build with hardening doesn't start
  • Tests

@jtojnar
Copy link
Contributor

jtojnar commented Dec 31, 2018

@ptrhlm ptrhlm requested a review from infinisil as a code owner January 1, 2019 22:40
@FRidh FRidh added this to the 19.03 milestone Jan 16, 2019
@ptrhlm ptrhlm changed the title WIP: virtualbox: 5.2.22 -> 6.0.0 WIP: virtualbox: 5.2.22 -> 6.0.2 Jan 28, 2019
@devhell
Copy link
Contributor

devhell commented Jan 28, 2019

Does 3D Accel work again with this version of VBox? Does anyone know?

@bendlas
Copy link
Contributor

bendlas commented Feb 1, 2019

I've tested this PR on my machine, after upgrading to 6.0.4 bendlas@1a73f8b

It doesn't seem to find its extension pack (installed in libexec due to a non-hardened build)

It does work on linux 4.20, though, which is an improvement over vbox 5 ;)

@ptrhlm ptrhlm changed the title WIP: virtualbox: 5.2.22 -> 6.0.2 virtualbox: 5.2.22 -> 6.0.4 Feb 2, 2019
@ptrhlm
Copy link
Contributor Author

ptrhlm commented Feb 2, 2019

I removed the WIP status, but I couldn't get the tests to work.
Most likely it's because nested virtualization stopped working (tests run VirtualBox guest inside of QEMU host).

Everything else should work, including 3D accel.

@flokli flokli mentioned this pull request Feb 11, 2019
10 tasks
@L-as
Copy link
Member

L-as commented Feb 15, 2019

What's blocking this?

@kalbasit
Copy link
Member

I tried it, it works on my side. @infinisil I'd like to merge this if it's alright with you.

@flokli
Copy link
Contributor

flokli commented Feb 15, 2019 via email

@wkral
Copy link
Contributor

wkral commented Feb 15, 2019

Please merge #55596 before or with this merge as that PR implies that this would break vagrant since the current version in unstable doesn't support virtualbox 6.

@kalbasit
Copy link
Member

kalbasit commented Feb 15, 2019

@wkral thank you for letting me know, I will merge #55596 after this one.

@flokli Let's wait to hear from @infinisil in this case!

@ptrhlm
Copy link
Contributor Author

ptrhlm commented Feb 18, 2019

@flokli As far I can tell, hardening and extension pack work.

I wasn't able to get the NixOS tests to run and fixing them is beyond my abilities.

@flokli
Copy link
Contributor

flokli commented Feb 20, 2019

@aszlig do you have time to dig into the virtualbox tests?

@ptrhlm ptrhlm changed the title virtualbox: 5.2.22 -> 6.0.4 virtualbox: 5.2.26 -> 6.0.4 Apr 10, 2019
@what-the-functor
Copy link

what-the-functor commented Apr 14, 2019

I'm happy to test this on macOS, although I'm a bit new to Nix. Can someone guide me on the appropriate process to check this out, and test it?

@what-the-functor
Copy link

I've created a Darwin specific package, here what-the-functor@d0d87fc

@flokli
Copy link
Contributor

flokli commented Apr 15, 2019

@tonylotts I don't think virtualbox 6.0.4 completly broken for linux, it's just that the nixos vm tests don't work anymore (maybe due to the nested virtualization happening here) so we don't spot things suddenly breaking, which is why I'm hesitant to bump it without fixing the tests too…

Note the darwin-specific virtualbox6 derivation you proposed doesn't build VirtualBox, but simply unpacks a .dmg.

@what-the-functor
Copy link

what-the-functor commented Apr 17, 2019

@flokli, yes I've purposely used the pre-built binary; although I acknowledge that the community preference is to build from source. As I understand it, pre-built binaries are cached. In the case that VirtualBox is already available in pre-built form, can/should that be cached?

@flokli
Copy link
Contributor

flokli commented Apr 17, 2019 via email

@what-the-functor
Copy link

Got it.

@what-the-functor
Copy link

It turns out that the macOS version of VirtualBox provides kernel extensions. A macOS derivation for VirtualBox would require nix-darwin, and support for kernel extensions LnL7/nix-darwin#91.

@flokli
Copy link
Contributor

flokli commented Apr 17, 2019

@tonylotts so no matter what variant we use, the darwin version depends on LnL7/nix-darwin#91 or a successor to be merged?

@devhell
Copy link
Contributor

devhell commented Apr 18, 2019

6.0.6 has been released. Not that it matters that much, I guess, right now.

@what-the-functor
Copy link

@flokli, yes

@flokli
Copy link
Contributor

flokli commented Apr 22, 2019

@devhell I tried bumping to 6.0.6, but it seems some patches need to be adjusted. Did you do that already somewhere?

@flokli
Copy link
Contributor

flokli commented Apr 22, 2019

The release notes mention some nested (AMD) virtualization fixes - I guess we still should see if things have improved.

@devhell
Copy link
Contributor

devhell commented Apr 23, 2019

@flokli I've not been able to, no. Sorry. :/

@flokli
Copy link
Contributor

flokli commented Apr 27, 2019

@ptrhlm could you get to that?

@ptrhlm
Copy link
Contributor Author

ptrhlm commented May 1, 2019

@flokli I've removed unnecessary kernel module patches. Also, I've moved patching of kernel module sources to the main package, so now unaligned patch will fail earlier.

Tests still fail on my Intel machine.

@ptrhlm ptrhlm changed the title virtualbox: 5.2.26 -> 6.0.4 virtualbox: 5.2.28 -> 6.0.6 May 1, 2019
@bendlas bendlas self-assigned this May 3, 2019
@flokli
Copy link
Contributor

flokli commented May 5, 2019

@ptrhlm thanks for the cleanup! I gave the tests a try on an AMD machine too, unfortunately, they fail there, too:

nix log /nix/store/pnbnmxz36kxdd33b8mj9v6qh2i7hmiws-vm-test-run-virtualbox-headless.drv looks most scary:

machine# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
machine# !!
machine# !!         VCPU0: Guru Meditation -2403 (VERR_TRPM_DONT_PANIC)
machine# !!
machine# !! TRAP=0e ERRCD=0000000000000010 CR2=00000000a082bf60 EIP=a082bf60 Type=0 cbInstr=ff
machine# !! EIP is not in any code known to VMM!
machine# !!
machine# !!
machine# !!

@flokli flokli mentioned this pull request May 5, 2019
10 tasks
@flokli
Copy link
Contributor

flokli commented May 8, 2019

closed in favour of #60943.

@flokli flokli closed this May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet