Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megasync: init at 3.7.1.0 #53126

Merged
merged 3 commits into from Feb 8, 2019
Merged

megasync: init at 3.7.1.0 #53126

merged 3 commits into from Feb 8, 2019

Conversation

ElXreno
Copy link
Contributor

@ElXreno ElXreno commented Dec 31, 2018

Motivation for this change

Add MEGASync for syncing files with MEGA

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

];
buildInputs = [
autoconf
automake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoconf and automake should go into nativeBuildInputs

buildInputs = [
autoconf
automake
bash
Copy link
Member

@markuskowa markuskowa Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash is part of stdenv and can be removed from here

libtool
libuv
libzen
pkgconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgconfig is usually only needed at build time and should be in nativeBuildInputs


buildPhase = ''
qmake CONFIG+="release" MEGA.pro
lrelease MEGASync/MEGASync.pro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the above commands in preBuild we do not need to override the build phase then.


configurePhase = ''
cd src/MEGASync/mega
./autogen.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the lines above in preConfigure.

--with-zlib \
--without-freeimage \
--without-termcap \
--without-ffmpeg
Copy link
Member

@markuskowa markuskowa Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...this can then be given as configureFlags


nativeBuildInputs = [
doxygen
libsodium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is libsodium really only needed at build time?

@markuskowa markuskowa self-assigned this Jan 3, 2019
@matthewbauer matthewbauer merged commit 7a1d22c into NixOS:master Feb 8, 2019
@markuskowa
Copy link
Member

markuskowa commented Feb 8, 2019

@matthewbauer the comments above have not really been resolved. I recommend reverting the merge until the issues mentioned are addressed.

@matthewbauer
Copy link
Member

Oops sorry! Wasn't looking at those.

markuskowa added a commit that referenced this pull request Feb 9, 2019
@KiaraGrouwstra
Copy link
Contributor

is there a new outstanding PR we can follow for this?

@markuskowa
Copy link
Member

@tycho01 I am happy to review the PR if someone opens up a new (improved) version.

@NathanielHill
Copy link
Contributor

I'm going to switch over to NixOS in about a month or two. If this isn't merged by then, I'll take a look at contributing here as my first go at NixOS packaging 👍

michojel added a commit to michojel/NixOS that referenced this pull request Feb 17, 2019
copied from: NixOS/nixpkgs#53126
author of derivation: ElXreno

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel michojel mentioned this pull request Jun 23, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants