New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
megasync: init at 3.7.1.0 #53126
megasync: init at 3.7.1.0 #53126
Conversation
]; | ||
buildInputs = [ | ||
autoconf | ||
automake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoconf and automake should go into nativeBuildInputs
buildInputs = [ | ||
autoconf | ||
automake | ||
bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash is part of stdenv and can be removed from here
libtool | ||
libuv | ||
libzen | ||
pkgconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgconfig is usually only needed at build time and should be in nativeBuildInputs
|
||
buildPhase = '' | ||
qmake CONFIG+="release" MEGA.pro | ||
lrelease MEGASync/MEGASync.pro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put the above commands in preBuild
we do not need to override the build phase then.
|
||
configurePhase = '' | ||
cd src/MEGASync/mega | ||
./autogen.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put the lines above in preConfigure
.
--with-zlib \ | ||
--without-freeimage \ | ||
--without-termcap \ | ||
--without-ffmpeg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...this can then be given as configureFlags
|
||
nativeBuildInputs = [ | ||
doxygen | ||
libsodium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is libsodium really only needed at build time?
@matthewbauer the comments above have not really been resolved. I recommend reverting the merge until the issues mentioned are addressed. |
Oops sorry! Wasn't looking at those. |
This reverts commit 7a1d22c.
is there a new outstanding PR we can follow for this? |
@tycho01 I am happy to review the PR if someone opens up a new (improved) version. |
I'm going to switch over to NixOS in about a month or two. If this isn't merged by then, I'll take a look at contributing here as my first go at NixOS packaging 👍 |
copied from: NixOS/nixpkgs#53126 author of derivation: ElXreno Signed-off-by: Michal Minář <mic.liamg@gmail.com>
Motivation for this change
Add MEGASync for syncing files with MEGA
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)