Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sway: Improve the wrapper #53138

Merged
merged 1 commit into from Jan 4, 2019
Merged

nixos/sway: Improve the wrapper #53138

merged 1 commit into from Jan 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2019

Port a change by @primeos from sway-beta module to sway module.

#51316

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/sway: Improve the wrapper
d15425f 
Port a change by @primeos from sway-beta module to sway module.

#51316
@ghost ghost requested a review from infinisil as a code owner January 1, 2019 08:23
@primeos primeos self-assigned this Jan 4, 2019
primeos
primeos approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks :)

@primeos primeos merged commit 65c9539 into NixOS:master Jan 4, 2019
@ghost ghost deleted the sway branch January 4, 2019 11:53
@ghost
Copy link
Author

ghost commented Jan 4, 2019

@primeos Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees

@primeos primeos

Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @GrahamcOfBorg