Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trappist optimization results #2047

Merged
merged 6 commits into from
Dec 31, 2018
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 31, 2018

No description provided.

astronomy/trappist_dynamics_test.cpp Show resolved Hide resolved
astronomy/trappist_dynamics_test.cpp Outdated Show resolved Hide resolved
astronomy/trappist_dynamics_test.cpp Outdated Show resolved Hide resolved
tools/generate_configuration.cpp Show resolved Hide resolved
ParseQuantity<GravitationalParameter>(
body.gravitational_parameter());
gravity_model_cfg << " gravitational_parameter = "
<< std::scientific
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DebugString(gravitational_parameter) (in SI units, rather than multiples of SI units) would avoid losing an ULP from the division by 1 000 000 000.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use km^3/s^2 everywhere, now is not the time to change this.

CHECK_LT(χ², 359.0);
CHECK_GT(χ², 358.0);
EXPECT_LT(χ², 359.0);
EXPECT_GT(χ², 358.0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXPECT_THAT(χ², AllOf(Gt(358.0), Lt(359.0)));

@eggrobin eggrobin added the LGTM label Dec 31, 2018
@pleroy pleroy merged commit 4349dfe into mockingbirdnest:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants