-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trappist optimization results #2047
Conversation
ParseQuantity<GravitationalParameter>( | ||
body.gravitational_parameter()); | ||
gravity_model_cfg << " gravitational_parameter = " | ||
<< std::scientific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DebugString(gravitational_parameter)
(in SI units, rather than multiples of SI units) would avoid losing an ULP from the division by 1 000 000 000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use km^3/s^2
everywhere, now is not the time to change this.
astronomy/trappist_dynamics_test.cpp
Outdated
CHECK_LT(χ², 359.0); | ||
CHECK_GT(χ², 358.0); | ||
EXPECT_LT(χ², 359.0); | ||
EXPECT_GT(χ², 358.0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXPECT_THAT(χ², AllOf(Gt(358.0), Lt(359.0)));
No description provided.