Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytrainer: 1.12.1 → 2.0.0 #53125

Closed
wants to merge 1 commit into from
Closed

pytrainer: 1.12.1 → 2.0.0 #53125

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 31, 2018 •
edited

Motivation for this change

Finally GTK 3 support #18559

There are still some rough edges, which I reported upstream; also created a patch for modern webkitgtk support pytrainer/pytrainer#174

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rycee July 15, 2019 12:49
@rycee rycee self-assigned this Jul 15, 2019
@rycee
Copy link
Member

rycee commented Jul 15, 2019

Ah, I was just working on upgrading to 2.0.0 yesterday. I'll have a look at this, I think your setup is nicer. Thanks!

@jtojnar jtojnar changed the title pytrainer: 1.12.1 → 2.0.0rc1 pytrainer: 1.12.1 → 2.0.0 Jul 16, 2019
@ofborg ofborg bot requested a review from rycee July 16, 2019 05:41
@rycee
Copy link
Member

rycee commented Jul 17, 2019

Thanks for the update, I've tried it and everything seems to work great! Rebased to master in 99e72dc.

@rycee rycee closed this Jul 17, 2019
@jtojnar jtojnar deleted the pytrainer-2 branch July 17, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees

@rycee rycee

Labels
2.status: work-in-progress 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @rycee @infinisil @GrahamcOfBorg