Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qolibri: init at 2018-11-14 #53135

Merged
merged 1 commit into from Feb 8, 2019
Merged

qolibri: init at 2018-11-14 #53135

merged 1 commit into from Feb 8, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 1, 2019 •
edited

Motivation for this change

This adds qolibri, an EPWING viewer that can search and render Japanese EPWING dictionaries.

This renders some EPWING dictionaries more correctly than GoldenDict; e.g. qolibri renders the entries in NHKACT ("ＮＨＫ 日本語発音アクセント辞典") correctly, while GoldenDict stacks the embedded kana images vertically.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested that this works on NixOS with an empty ~/.config/qolibri as well as an existing config.

This package does not work on other Linux distributions because something in Qt requires libGL #9415

Platform is set to linux because the build fails on Darwin (tested unsandboxed macOS 10.14) with

Log 
installing 'qolibri-2018-11-14'
these derivations will be built:
  /nix/store/0af4ja5haps3s7l24wnixf8rjn4ncb44-qolibri-2018-11-14.drv
building '/nix/store/0af4ja5haps3s7l24wnixf8rjn4ncb44-qolibri-2018-11-14.drv'...
unpacking sources
unpacking source archive /nix/store/c6sw7y737dwfy6k3zbaadifb2n02anq4-source
source root is source
patching sources
configuring
fixing cmake files...
cmake flags: -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/2lc0lf78s5p56dqimxnss5y1f1xwhwzk-qolibri-2018-11-14/include -DCMAKE_INSTALL_LIBDIR=/nix/store/2lc0lf78s5p56dqimxnss5y1f1xwhwzk-qolibri-2018-11-14/lib -DCMAKE_INSTALL_NAME_DIR=/nix/store/2lc0lf78s5p56dqimxnss5y1f1xwhwzk-qolibri-2018-11-14/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_DEPLOYMENT_TARGET= -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=last -DCMAKE_STRIP=/nix/store/k8d4p5889qg0smgcgbwp1apy6zm102qh-cctools-binutils-darwin/bin/strip -DCMAKE_RANLIB=/nix/store/k8d4p5889qg0smgcgbwp1apy6zm102qh-cctools-binutils-darwin/bin/ranlib -DCMAKE_AR=/nix/store/k8d4p5889qg0smgcgbwp1apy6zm102qh-cctools-binutils-darwin/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/2lc0lf78s5p56dqimxnss5y1f1xwhwzk-qolibri-2018-11-14
-- The C compiler identification is Clang 5.0.2
-- The CXX compiler identification is Clang 5.0.2
-- Check for working C compiler: /nix/store/vcgm727r50w7mwy7fxmswhq4ffj2qqf0-clang-wrapper-5.0.2/bin/clang
-- Check for working C compiler: /nix/store/vcgm727r50w7mwy7fxmswhq4ffj2qqf0-clang-wrapper-5.0.2/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /nix/store/vcgm727r50w7mwy7fxmswhq4ffj2qqf0-clang-wrapper-5.0.2/bin/clang++
-- Check for working CXX compiler: /nix/store/vcgm727r50w7mwy7fxmswhq4ffj2qqf0-clang-wrapper-5.0.2/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /nix/store/jnlskid65f1wsq8zws61cdwyalsxdc1w-qtbase-5.11.1-dev/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
  By not providing "FindQt5WebEngine.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5WebEngine", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5WebEngine" with
  any of the following names:

    Qt5WebEngineConfig.cmake
    qt5webengine-config.cmake

  Add the installation prefix of "Qt5WebEngine" to CMAKE_PREFIX_PATH or set
  "Qt5WebEngine_DIR" to a directory containing one of the above files.  If
  "Qt5WebEngine" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:16 (find_package)


-- Configuring incomplete, errors occurred!
See also "/private/var/folders/v2/6gkg_95d1pzcvkj7xnx2wgzr0000gn/T/nix-build-qolibri-2018-11-14.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/0af4ja5haps3s7l24wnixf8rjn4ncb44-qolibri-2018-11-14.drv' failed with exit code 1
error: build of '/nix/store/0af4ja5haps3s7l24wnixf8rjn4ncb44-qolibri-2018-11-14.drv' failed

@matthewbauer matthewbauer merged commit e9c9202 into NixOS:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @matthewbauer @GrahamcOfBorg