python3Packages: add Sanic HTTP Server (and dependencies) #53144
Conversation
Signed-off-by: Austin Seipp <aseipp@pobox.com>
Signed-off-by: Austin Seipp <aseipp@pobox.com>
Signed-off-by: Austin Seipp <aseipp@pobox.com>
|
@GrahamcOfBorg build python3Packages.uvloop python3Packages.httptools python3Packages.sanic |
| let | ||
| # Ideally, websockets 7.0 will be supported in the future, but | ||
| # for now, sanic requires 6.x | ||
| ws = websockets.overrideAttrs (_: { |
There was a problem hiding this comment.
We can't have a different version of a package in python-packages.nix as that will result in collisions.
There was a problem hiding this comment.
Am I missing something here, or are you suggesting that python-packages.nix infrastructure cannot feature any version overrides in any expressions? That seems... extremely not-Nix like. Or are you worried that ws will end up pulled in by possible downstream users of sanic (due to propagatedBuildInputs)?
There was a problem hiding this comment.
Python cannot handle having multiple versions of a module in a single closure. If someone wants to build a Python env with this package, and another package that uses the other version of ws, they will get a collision. Now, one could say that is a risk/problem for the user whenever they compose such environment, but that would severely reduce the quality of the package set.
|
Are there any updates on this pull request, please? |
|
Unfortunately not. Sanic has moved to supporting websockets 0.7.x, but the same problem has cropped up yet again: websockets is now on 0.8.x, making these packages mutually exclusive in the same way. I'm closing this since I have little hope this will be rectified anytime soon. |
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)