Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimUtils: derive pname from the plugin string #53121

Merged
merged 1 commit into from Dec 31, 2018
Merged

vimUtils: derive pname from the plugin string #53121

merged 1 commit into from Dec 31, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 31, 2018 •
edited

Motivation for this change

For backwards compatibility. The user may specify their own plugins
without the pname attribute. In that case the attrname of the plugin
(given as a string) is the pname.

Fixes #53112

CC @8573

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
vimUtils: derive pname from the plugin string
1482ef8 
For backwards compatibility. The user may specify their own plugins
without the pname attribute. In that case the attrname of the plugin
(given as a string) is the pname.

Fixes NixOS#53112
@timokau timokau mentioned this pull request Dec 31, 2018
Closed
@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

@GrahamcOfBorg build vimUtils.test_vim_with_custom_plugin

@timokau timokau merged commit a0dc57e into NixOS:master Dec 31, 2018
@timokau timokau deleted the vim-derive-pname branch December 31, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg