Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abduco: 0.6 -> 2018-05-16 #53147

Merged
merged 1 commit into from Jan 14, 2019
Merged

abduco: 0.6 -> 2018-05-16 #53147

merged 1 commit into from Jan 14, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jan 1, 2019

Motivation for this change

There was no release since March 2016, but activity on master till May 2018. I've been using this version without issues, so far.

The messy diff is due to reformatting (meta to the bottom, 2-space indentation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner
Copy link
Member Author

tilpner commented Jan 1, 2019

@GrahamcOfBorg build abduco

@grahamc grahamc merged commit 202bee9 into NixOS:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tilpner @jtojnar @grahamc @GrahamcOfBorg