patchbay, patchwork: init with appimage-run #53156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Jan 1, 2019
tilpner
suggested changes
Jan 27, 2019
There was a problem hiding this comment.
This is not how appimage-run is meant to be used, it's meant to be a quick escape hatch, like steam-run. appimage-run unnecessarily extracts into the users home directory.
I built an alternative at some point, I'll see if I can find and fix it pr'd as #54693. For the moment, I'd like to find a better option instead of merging this
tilpner
added a commit
to tilpner/nixpkgs
that referenced
this pull request
Feb 1, 2019
The appimageTools attrset contains utilities to prevent the usage of appimage-run to package AppImages, like done/attempted in NixOS#49370 and NixOS#53156. This has the advantage of allowing for per-package environment changes, and extracts into the store instead of the users home directory. The package list was extracted into appimageTools to prevent duplication.
tilpner
added a commit
to tilpner/nixpkgs
that referenced
this pull request
Feb 23, 2019
The appimageTools attrset contains utilities to prevent the usage of appimage-run to package AppImages, like done/attempted in NixOS#49370 and NixOS#53156. This has the advantage of allowing for per-package environment changes, and extracts into the store instead of the users home directory. The package list was extracted into appimageTools to prevent duplication.
|
We already have patchwork in master. |
|
Patchbay could still actually go in. Even so, I do agree with @tilpner, we should not run an appimage. |
|
@astro Do you plan to finish this? |
|
Would love to see patchbay as well as just patchwork, any one working on that? @ehmry? |
|
Can we close this PR? |
|
@veprbl Patchwork has landed in nixpkgs regardless of this PR. 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Template:
standardnotesThings done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)