Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suitesparse: 5.3.0 -> 5.4.0 #53128

Merged
merged 1 commit into from Jan 1, 2019
Merged

suitesparse: 5.3.0 -> 5.4.0 #53128

merged 1 commit into from Jan 1, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 31, 2018 •
edited

Motivation for this change

Latest upstream release, maybe/hopefully a fix for #52709.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request Dec 31, 2018
Closed
@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

@GrahamcOfBorg build suitesparse

Looks like it doesn't do that automatically for some reason.

@timokau
Copy link
Member Author

timokau commented Jan 1, 2019

nix-review only shows a Julia test failure, but that was not caused by this PR (cc @7c6f434c).

@timokau timokau merged commit 04ba895 into NixOS:master Jan 1, 2019
@timokau
Copy link
Member Author

timokau commented Jan 1, 2019

Here's the log for julia: http://sprunge.us/5NBIoN

@timokau timokau deleted the suitesparse-5.4.0 branch January 1, 2019 14:48
@7c6f434c
Copy link
Member

7c6f434c commented Jan 1, 2019

Strange, because julia seems to work on master

@timokau
Copy link
Member Author

timokau commented Jan 2, 2019

I can confirm that master builds fine. Not sure what caused the issue I saw -- either there was some issue that has since been fixed or maybe the tests just ran out of ram (which they need a ridiculous amount of). Sorry for the false alarm.

@7c6f434c
Copy link
Member

7c6f434c commented Jan 2, 2019

Ah I see. It might have been Julia 0.6 problem, which is a known and old problem with some trace of hope that someone still using abandoned 06.-only libraries will come up with a master-applicable fix.

@timokau
Copy link
Member Author

timokau commented Jan 2, 2019

Why is 0.6 default if there already is a 1.0?

@7c6f434c
Copy link
Member

7c6f434c commented Jan 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @7c6f434c @GrahamcOfBorg