Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtscreen: init at 0.3.1 #53472

Merged
merged 2 commits into from Feb 24, 2019
Merged

Conversation

borisbabic
Copy link
Contributor

Motivation for this change

Add virtscreen, a tool to help use another device (ex. tablet) as an external display over vnc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Along with virtscreen this pull request also adds a dependency, Quamash.

I'm not sure if I packaged it the best way. It depends on one of pyqt4/pyqt5/pyside and won't build without one of them and I'm not sure if I handled that in the best way.

@worldofpeace
Copy link
Contributor

Btw the initialization of quamash needs to be in a separate commit.

@worldofpeace
Copy link
Contributor

#53472 (comment)
but I couldn't get it to work, no tests would be run and it didn't seem like there were any tests there at that point.

This is totally correct, because after inspecting the archive nix fetched, they're no tests 😄
Though they should be there, so we should switch from using fetchPypi to fetchFromGitHub since they're distributed there.

Also add a comment above it with "No tests in PyPI tarball".

@ryantm
Copy link
Member

ryantm commented Feb 18, 2019

@GrahamcOfBorg build virtscreen

@ryantm
Copy link
Member

ryantm commented Feb 18, 2019

Looks okay to merge to me.

@worldofpeace Are you happy with this now?

@worldofpeace
Copy link
Contributor

Looks okay to merge to me.

@worldofpeace Are you happy with this now?

I'll push the last nitpicks and then it should be fine to merge.

@worldofpeace
Copy link
Contributor

Can't test if it works since my system doesn't support SystemTrayIcon anymore
kbumsik/VirtScreen#22

@ryantm
Copy link
Member

ryantm commented Feb 23, 2019

@GrahamcOfBorg eval

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build virtscreen

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

Well I'll merge it now, @borisbabic can test it some more after.

@ryantm ryantm merged commit a13f0a1 into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants