New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtscreen: init at 0.3.1 #53472
virtscreen: init at 0.3.1 #53472
Conversation
Btw the initialization of |
bd89fcd
to
cbf262b
Compare
This is totally correct, because after inspecting the archive nix fetched, they're no tests 😄 Also add a comment above it with "No tests in PyPI tarball". |
cbf262b
to
f3331fb
Compare
f3331fb
to
18e8da4
Compare
@GrahamcOfBorg build virtscreen |
Looks okay to merge to me. @worldofpeace Are you happy with this now? |
I'll push the last nitpicks and then it should be fine to merge. |
18e8da4
to
712f5f9
Compare
Can't test if it works since my system doesn't support SystemTrayIcon anymore |
@GrahamcOfBorg eval |
@GrahamcOfBorg build virtscreen |
Well I'll merge it now, @borisbabic can test it some more after. |
Motivation for this change
Add virtscreen, a tool to help use another device (ex. tablet) as an external display over vnc.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Along with virtscreen this pull request also adds a dependency, Quamash.
I'm not sure if I packaged it the best way. It depends on one of pyqt4/pyqt5/pyside and won't build without one of them and I'm not sure if I handled that in the best way.