Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #53483

Merged
merged 228 commits into from Jan 12, 2019
Merged

Staging next #53483

merged 228 commits into from Jan 12, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dtzWill and others added 30 commits December 19, 2018 12:08
https://savannah.gnu.org/forum/forum.php?forum_id=9332

Similar to gnused update, hash not obtained from mirrors
(since they currently 404 for this) but nix-prefetch-url
on master gnu site.
Fixes bug in some uses of '\b' in certain locales;
same bug was introduced and fixed in gnused 4.6 -> 4.7.
@vcunat
Copy link
Member

vcunat commented Jan 12, 2019

Do you know of any blockers?

Hydra link: https://hydra.nixos.org/eval/1499909?compare=1499904 It's a bit messy due to various transient problems: on darwin it was one machine killing builds (usually during unpacking), on aarch64 big builds sometimes time out now. Still, there's some security stuff and a fix for a possibly nasty gtk3 problem, so I'd be inclined to merge to master within one day.

Before this commit it built fine a few times for me,
i.e. without the single test, but it failed on Hydra anyway.
I guess jtojnar also tested the final expression with all tests,
so apparently they are sensitive the the kind of machine they run on.
@vcunat vcunat merged commit 3131a8e into master Jan 12, 2019
vcunat added a commit that referenced this pull request Jan 26, 2019
It got broken by a6fc462 #53483.
But IMO it's *this* expression that was written in a too fragile way.

(cherry picked from commit 2c22610)
vcunat added a commit that referenced this pull request Jan 26, 2019
It got broken by 74a64a8 #53483.
But IMO it's *this* expression that was written in a too fragile way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet