Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: don't overwrite makeFlagsArray in the example #53501

Merged
merged 1 commit into from Jan 23, 2019
Merged

doc: don't overwrite makeFlagsArray in the example #53501

merged 1 commit into from Jan 23, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 6, 2019 •
edited

Motivation for this change

Arrays like these should be appended to instead of overwritten in almost
every case to avoid loosing the existing flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
doc: don't overwrite makeFlagsArray in the example
e279767 
Arrays like these should be appended to instead of overwritten in almost
every case to avoid loosing the existing flags.
@danbst danbst merged commit 506d8ea into NixOS:master Jan 23, 2019
@danbst
Copy link
Contributor

danbst commented Jan 23, 2019

sounds reasonable

@LnL7 LnL7 deleted the manual-makeflagsarray branch January 23, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @danbst @GrahamcOfBorg