Fix #7017: Conditional orders enum updated without savegame version bump #7019
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be better to avoid a savegame conversion if possible. Can we not just move enum value to the end, and accept that savegames from that specific revision are incorrect? |
|
Main issue with moving the value is UX. The options are presented in definition order in the UI, so moving "max reliability" (the new one) to the end separates it from "(current) reliability". |
|
Well that's just bad UI design :/ |
|
No you're right, the order in the UI does not have to match the order in the enum, I just discovered. Going to change the patch to not bump savegame version. |
|
This is definitely a better fix, thanks. |
PeterN
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7017 changed the conditional orders conditions enum by adding a value in the middle. This breaks loading old savegames that use conditional orders. Fix this by moving the new enum value to the end, while keeping the UI list order the same.
Saving this orders list in 1.8.0:
Loads as this orders list with the #7017 patch but without this fix:
