lighttpd: Unbreak on darwin, enable tests #53488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It is disabled by default in lighttpd itself * Darwin doesn’t seem to have a function in libuiid that it needs
* Unbreak darwin * It was unused anyway, as it is disabled by default * Now there is an feature-argument to enable it
They seem to pass now, so why not.
|
(FTR, I am not sure why the tests were disabled, I have no issues with them. Maybe they were fixed in a new release, or maybe they will still fail on Linux.) |
bjornfor
approved these changes
Jan 6, 2019
|
Indeed they do: https://nix-cache.s3.amazonaws.com/log/pxwl8pny1g2fyqipcyqrqr8v1fa2r5jd-lighttpd-1.4.52.drv I have a feeling that weak sandboxing on Darwin helps them pass. |
7c6f434c
added a commit
to 7c6f434c/nixpkgs
that referenced
this pull request
Jan 11, 2019
The tests were enabled in NixOS#53488 and succeeded on Darwin; on Linux they still failed because of empty hostname inside the sandbox (we have no UTS-namespace hostname and I think no /etc/hosts). Nix on Darwin lacks powerful enough sandboxing, so there were no problems on Darwin. Patching the tests to fallback to "127.0.0.1" if hostname of the localhost cannot be retrieved matches the behaviour of lighttpd itself and allows the tests to pass. Not sure if having no hostname in the test environment is a bit too weird for the upstream to care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)