Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uriparser: 0.9.0 -> 0.9.1 [18.09] #53517

Merged

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Jan 6, 2019

Motivation for this change

Backporting #53477 to 18.09 since it's a security fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r? @joachifm
cc @hartwork

(cherry picked from commit 83ba7be)
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build uriparser

@worldofpeace worldofpeace merged commit c295034 into NixOS:release-18.09 Jan 7, 2019
@andrew-d andrew-d deleted the andrew/uriparser-0.9.1-18.09 branch January 7, 2019 00:10
@andrew-d
Copy link
Contributor Author

andrew-d commented Jan 7, 2019

@worldofpeace - Thanks!

@worldofpeace
Copy link
Contributor

@andrew-d You're welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants