Skip to content

Bugs in the console UI #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DasSkelett opened this issue Jan 6, 2019 · 5 comments · Fixed by #2634
Closed

Bugs in the console UI #2633

DasSkelett opened this issue Jan 6, 2019 · 5 comments · Fixed by #2634
Labels
Bug Something is not working as intended ConsoleUI Issues affecting the interactive console UI Windows Issues specific for Windows

Comments

@DasSkelett
Copy link
Member

DasSkelett commented Jan 6, 2019 •
edited
Loading

Background

CKAN Version:
1.25.4

Operating System:
Windows 10

Keyboard layout:
German QWERTZ without numpad

Problem

Found some bugs:

First, key issue again: On a German QWERTZ keyboard without numpad, the +-key is not working to install mods:
See: (left to the Enter key)

KB Germany.svg
CC BY-SA 3.0, Link

key data:

Key: OemPlus
KeyChar: 0x2b
Modifiers: 0

Second, CTRL-F is not working on Windows (10) in command line if Enable CTRL shortcuts (or something like this, only have the exact wording in German) is activated, which is by default.
I think this applies for all common CTRL shortcuts (like ctrl-c, ctrl-v, ctrl-a...) which have an assigned action in the cmdline.
Don't know if there's any way to circumvent this. Maybe advise the user to deactivate it on launch.

Also, I think it would be nice to have the website of a mod linked in the info section, maybe together with a keyboard shortcut to open it in the browser.
@HebaruSan
Copy link
Member

The web site links are in the F10 menu of the mod info screen:

image

We already listen for OemPlus on Windows, but I guess you don't have to press shift with that keyboard?

CKAN/ConsoleUI/Toolkit/Keys.cs

Lines 115 to 119 in 48d29f1

public static readonly ConsoleKeyInfo Plus = new ConsoleKeyInfo(
(System.Char)'+',
Platform.IsWindows ? ConsoleKey.OemPlus : ConsoleKey.Add,
Platform.IsWindows ? true : false, false, false
);

I don't have Windows 10, but you can still tab to the search field even if your terminal is configured to not send Control key combinations.

@HebaruSan HebaruSan added Bug Something is not working as intended Windows Issues specific for Windows ConsoleUI Issues affecting the interactive console UI labels Jan 6, 2019
@HebaruSan
Copy link
Member

Are there any settings in this part of your registry that look related to "Enable new ctrl key shortcuts"?

image

@DasSkelett
Copy link
Member Author

DasSkelett commented Jan 6, 2019 •
edited
Loading

Ah, didn't find it in the F10 menu.

No, don't have to press shift to enter a plus.

Found something in Computer\HKEY_CURRENT_USER\Console\%SystemRoot%_System32_cmd.exe:

image

@HebaruSan HebaruSan mentioned this issue Jan 6, 2019
Merged
@DasSkelett
Copy link
Member Author

DasSkelett commented Jan 6, 2019 •
edited
Loading

Can you change "F10 - Menu" to "F10 - Links" in the mod overview? That would make it a bit more clear where they are.

@HebaruSan
Copy link
Member

Sure, see #2635.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something is not working as intended ConsoleUI Issues affecting the interactive console UI Windows Issues specific for Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle plus without shift in ConsoleUI HebaruSan/CKAN
2 participants
@HebaruSan @DasSkelett