Improve runserver command to work with reloader and debugger #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runserver command was broken by a flask upgrade in #308, causing it to lose the app context when the reloader restarted the app. Copy the flask.cli.run_command command to our manage.py so that it acts like `flask run`, including the debugger and reloader behaviour. Ensure that we also reload on changes to config.RELOAD_ON_FILES Fixes AB-327
paramsingh
reviewed
Jan 9, 2019
| app = flask.cli.DispatchingApp(info.load_app, use_eager_loading=eager_loading) | ||
| reload_on_files = info.load_app().config['RELOAD_ON_FILES'] | ||
|
|
||
| from werkzeug.serving import run_simple |
There was a problem hiding this comment.
Why are we importing this here?
There was a problem hiding this comment.
because I copied this directly from the flask cli: https://github.com/pallets/flask/blob/a74864ec229141784374f1998324d2cbac837295/flask/cli.py#L782
Perhaps I should add a comment to this method saying where it comes from?
There was a problem hiding this comment.
Ah, I already do in the docstring:
This is a copy of flask.cli.run_command
perhaps it can be more explicit with a github link
paramsingh
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runserver command was broken by a flask upgrade in #308, causing
it to lose the app context when the reloader restarted the app.
Copy the flask.cli.run_command command to our manage.py so that it acts
like
flask run, including the debugger and reloader behaviour.Ensure that we also reload on changes to config.RELOAD_ON_FILES
Fixes AB-327